Closed
Conversation
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon. |
Author
|
Taking a look at this it seems like |
mrowqa
commented
Apr 8, 2018
| unsafe { BrowsingContextIndex(NonZero::new_unchecked(8765)) }; | ||
| #[cfg(feature = "unstable")] | ||
| pub const TEST_BROWSING_CONTEXT_ID: BrowsingContextId = | ||
| BrowsingContextId { namespace_id: TEST_NAMESPACE, index: TEST_BROWSING_CONTEXT_INDEX }; |
Author
There was a problem hiding this comment.
Failed with:
error[E0015]: calls in constants are limited to constant functions, struct and enum constructors
--> components/msg/constellation_msg.rs:358:71
|
358 | pub const TEST_PIPELINE_INDEX: PipelineIndex = unsafe { PipelineIndex(NonZero::new_unchecked(5678)) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error[E0015]: calls in constants are limited to constant functions, struct and enum constructors
--> components/msg/constellation_msg.rs:364:35
|
364 | unsafe { BrowsingContextIndex(NonZero::new_unchecked(8765)) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: aborting due to 2 previous errors
Member
|
This will likely hit the same WebBluetooth test failures as #20474 (comment) which still need to be investigated. |
Member
|
By the way #20474 already takes care of the nonzero stuff. |
3 tasks
Author
|
Oh, I haven't noticed this PR. In this case my change looks redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer toolchain contains bugfix required by #14902.
./mach build -ddoes not report any errorsIt reports some warnings about deprecated items in rust-webvr-api.
./mach build-geckolibdoes not report any errors./mach test-tidydoes not report any errorsThis change is