-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Closed
Description
I discovered this while trying to figure out why #34986 was not passing tests involving websockets. Servo's websocket network integration diverges immediately from the normal Fetch implementation in
servo/components/net/resource_thread.rs
Line 355 in a014da5
| } => self.resource_manager.websocket_connect( |
servo/components/net/websocket_loader.rs
Lines 365 to 376 in a014da5
| // https://fetch.spec.whatwg.org/#websocket-opening-handshake | |
| http_state | |
| .hsts_list | |
| .read() | |
| .unwrap() | |
| .apply_hsts_rules(&mut req_builder.url); | |
| let req_url = req_builder.url.clone(); | |
| if should_be_blocked_due_to_bad_port(&req_url) { | |
| return Err("Port blocked".to_string()); | |
| } |
We should update our integration to follow https://websockets.spec.whatwg.org/#concept-websocket-establish and only enter websocket-specific code in https://fetch.spec.whatwg.org/#http-network-fetch .
Reactions are currently unavailable