Just plugging it in passes all the custom-elements/custom-element-registry/upgrade.html tests, but there's one related failure:

servo/tests/wpt/web-platform-tests/custom-elements/upgrading.html

Lines 209 to 226 in 90acd1a

    
           test(() => { 
        
               var log = []; 
        
               customElements.define('infinite-cloning-element-1',class extends HTMLElement { 
        
                   constructor() { 
        
                       super(); 
        
                       log.push([this, 'begin']); 
        
                       // Potential infinite recursion: 
        
                       customElements.upgrade(this); 
        
                       log.push([this, 'end']); 
        
                   } 
        
               }); 
        
               assert_equals(log.length, 2); 
        
               const instance = document.querySelector("infinite-cloning-element-1"); 
        
               assert_array_equals(log[0], [instance, 'begin']); 
        
               assert_array_equals(log[1], [instance, 'end']); 
        
           }, 'Infinite constructor recursion with upgrade(this) should not be possible');

This seems like the reason https://html.spec.whatwg.org/multipage/custom-elements.html#upgrades specifies the element should be set to the definition before actually calling the constructor about it; I'll look into the Servo order of operations.

	test(() => {
	var log = [];

	customElements.define('infinite-cloning-element-1',class extends HTMLElement {
	constructor() {
	super();
	log.push([this, 'begin']);
	// Potential infinite recursion:
	customElements.upgrade(this);
	log.push([this, 'end']);
	}
	});

	assert_equals(log.length, 2);
	const instance = document.querySelector("infinite-cloning-element-1");
	assert_array_equals(log[0], [instance, 'begin']);
	assert_array_equals(log[1], [instance, 'end']);
	}, 'Infinite constructor recursion with upgrade(this) should not be possible');

Uh oh!

Implement CustomElementRegistry.upgrade #24989

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions