Skip to content

Debugger update broke the Android build #14171

@mmatyas

Description

@mmatyas

A few days ago rust-websocket was replaced with ws-rs in the debugger, and this change breaks the Android build currently.

ws-rs depends on mio, which in turn depends on nix, a dependency that wants to use the kernel signal definitions. It tries to create a sigaction structure here; the problem is that the type of sa_flags is architecture-dependent (int, unsigned int or unsigned long, see here), but nix defines it as an int here. (Note: we're using an older nix currently, but the problem still exists upstream).

In addition, it seems the type of the flags are defined incorrectly in libc too, as for example some of the possible flags are defined globally for notbsd targets as int here, despite that for other values ulong is used for notbsd/ android, int for notbsd/linux/other, and the remaining flags are not even defined for notbsd/linux/musl.

Related/blocks: #13154
cc @larsbergstrom

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions