Let resources timing entries be added to performance entry buffer.

gatowololo · gatowololo · commit 4a8bdce78a66 · 2019-06-07T16:44:44.000-07:00
Update relevant tests to properly report and expect failure.
Update manifest.
diff --git a/components/script/network_listener.rs b/components/script/network_listener.rs
@@ -62,7 +62,7 @@ pub fn submit_timing_data(
         PerformanceResourceTiming::new(global, url, initiator_type, None, resource_timing);
     global
         .performance()
-        .queue_entry(performance_entry.upcast::<PerformanceEntry>(), false);
+        .queue_entry(performance_entry.upcast::<PerformanceEntry>(), true);
 }
 
 impl<Listener: PreInvoke + Send + 'static> NetworkListener<Listener> {
diff --git a/tests/wpt/metadata/html/semantics/embedded-content/the-img-element/srcset/avoid-reload-on-resize.html.ini b/tests/wpt/metadata/html/semantics/embedded-content/the-img-element/srcset/avoid-reload-on-resize.html.ini
@@ -0,0 +1,4 @@
+[avoid-reload-on-resize.html]
+  [Avoid srcset image reloads when viewport resizes]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/resource-timing/idlharness.any.js.ini b/tests/wpt/metadata/resource-timing/idlharness.any.js.ini
@@ -70,9 +70,6 @@
   [PerformanceResourceTiming interface: resource must inherit property "workerStart" with the proper type]
     expected: FAIL
 
-  [PerformanceResourceTiming interface: resource must inherit property "initiatorType" with the proper type]
-    expected: FAIL
-
   [PerformanceResourceTiming interface: attribute transferSize]
     expected: FAIL
 
@@ -82,66 +79,36 @@
   [PerformanceResourceTiming interface: resource must inherit property "secureConnectionStart" with the proper type]
     expected: FAIL
 
-  [PerformanceResourceTiming interface: resource must inherit property "requestStart" with the proper type]
-    expected: FAIL
-
   [PerformanceResourceTiming interface: resource must inherit property "transferSize" with the proper type]
     expected: FAIL
 
   [PerformanceResourceTiming interface: resource must inherit property "domainLookupStart" with the proper type]
     expected: FAIL
 
-  [PerformanceResourceTiming interface: resource must inherit property "connectStart" with the proper type]
-    expected: FAIL
-
   [PerformanceResourceTiming interface: attribute decodedBodySize]
     expected: FAIL
 
-  [Stringification of resource]
-    expected: FAIL
-
-  [PerformanceResourceTiming interface: resource must inherit property "redirectStart" with the proper type]
-    expected: FAIL
-
   [PerformanceResourceTiming interface: resource must inherit property "toJSON()" with the proper type]
     expected: FAIL
 
-  [PerformanceResourceTiming interface: resource must inherit property "responseEnd" with the proper type]
-    expected: FAIL
-
   [PerformanceResourceTiming interface: resource must inherit property "redirectEnd" with the proper type]
     expected: FAIL
 
-  [PerformanceResourceTiming interface: resource must inherit property "nextHopProtocol" with the proper type]
-    expected: FAIL
-
   [PerformanceResourceTiming interface: resource must inherit property "domainLookupEnd" with the proper type]
     expected: FAIL
 
   [PerformanceResourceTiming interface: resource must inherit property "decodedBodySize" with the proper type]
     expected: FAIL
 
-  [PerformanceResourceTiming interface: resource must inherit property "fetchStart" with the proper type]
-    expected: FAIL
-
   [PerformanceResourceTiming interface: attribute encodedBodySize]
     expected: FAIL
 
-  [PerformanceResourceTiming interface: resource must inherit property "connectEnd" with the proper type]
-    expected: FAIL
-
   [PerformanceResourceTiming interface: resource must inherit property "encodedBodySize" with the proper type]
     expected: FAIL
 
   [PerformanceResourceTiming interface: operation toJSON()]
     expected: FAIL
 
-  [PerformanceResourceTiming interface: resource must inherit property "responseStart" with the proper type]
-    expected: FAIL
-
-  [PerformanceResourceTiming must be primary interface of resource]
-    expected: FAIL
-
   [PerformanceResourceTiming interface: attribute secureConnectionStart]
     expected: FAIL
 
diff --git a/tests/wpt/metadata/resource-timing/resource_TAO_origin.htm.ini b/tests/wpt/metadata/resource-timing/resource_TAO_origin.htm.ini
@@ -5,21 +5,9 @@
   [domainLookupEnd should not be 0 in timing-allow cross-origin request.]
     expected: FAIL
 
-  [connectStart should not be 0 in timing-allow cross-origin request.]
-    expected: FAIL
-
-  [connectEnd should not be 0 in timing-allow cross-origin request.]
-    expected: FAIL
-
-  [requestStart should not be 0 in timing-allow cross-origin request.]
-    expected: FAIL
-
   [responseStart should not be 0 in timing-allow cross-origin request.]
     expected: FAIL
 
-  [fetchStart should not be 0 in timing-allow cross-origin request.]
-    expected: FAIL
-
   [responseEnd should not be 0 in timing-allow cross-origin request.]
     expected: FAIL
 
@@ -29,3 +17,6 @@
   [secureConnectionStart should be 0 in cross-origin request since no ssl!]
     expected: FAIL
 
+  [The iframe should have one resource timing entry.]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/resource-timing/resource_TAO_zero.htm.ini b/tests/wpt/metadata/resource-timing/resource_TAO_zero.htm.ini
@@ -1,7 +1,4 @@
 [resource_TAO_zero.htm]
-  [fetchStart should be greater than 0 in cross-origin request.]
-    expected: FAIL
-
   [responseEnd should be greater than 0 in cross-origin request.]
     expected: FAIL
 
@@ -17,3 +14,15 @@
   [redirectEnd should be 0 in cross-origin request.]
     expected: FAIL
 
+  [connectEnd should be 0 in cross-origin request.]
+    expected: FAIL
+
+  [connectStart should be 0 in cross-origin request.]
+    expected: FAIL
+
+  [There should be one resource timing entry.]
+    expected: FAIL
+
+  [requestStart should be 0 in cross-origin request.]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/resource-timing/resource_connection_reuse.html.ini b/tests/wpt/metadata/resource-timing/resource_connection_reuse.html.ini
@@ -2,3 +2,18 @@
   [There should be 2 PerformanceEntries]
     expected: FAIL
 
+  [domainLookupEnd and fetchStart should be the same]
+    expected: FAIL
+
+  [connectStart and fetchStart should be the same]
+    expected: FAIL
+
+  [domainLookupStart and fetchStart should be the same]
+    expected: FAIL
+
+  [secureConnectionStart should be zero]
+    expected: FAIL
+
+  [connectEnd and fetchStart should be the same]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/resource-timing/resource_connection_reuse.https.html.ini b/tests/wpt/metadata/resource-timing/resource_connection_reuse.https.html.ini
@@ -2,3 +2,18 @@
   [There should be 2 PerformanceEntries]
     expected: FAIL
 
+  [secureConnectionStart and fetchStart should be the same]
+    expected: FAIL
+
+  [domainLookupEnd and fetchStart should be the same]
+    expected: FAIL
+
+  [connectStart and fetchStart should be the same]
+    expected: FAIL
+
+  [domainLookupStart and fetchStart should be the same]
+    expected: FAIL
+
+  [connectEnd and fetchStart should be the same]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/resource-timing/resource_connection_reuse_mixed_content.html.ini b/tests/wpt/metadata/resource-timing/resource_connection_reuse_mixed_content.html.ini
@@ -2,3 +2,18 @@
   [There should be 2 PerformanceEntries]
     expected: FAIL
 
+  [secureConnectionStart and fetchStart should be the same]
+    expected: FAIL
+
+  [domainLookupEnd and fetchStart should be the same]
+    expected: FAIL
+
+  [connectStart and fetchStart should be the same]
+    expected: FAIL
+
+  [domainLookupStart and fetchStart should be the same]
+    expected: FAIL
+
+  [connectEnd and fetchStart should be the same]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/resource-timing/resource_connection_reuse_mixed_content_redirect.html.ini b/tests/wpt/metadata/resource-timing/resource_connection_reuse_mixed_content_redirect.html.ini
@@ -2,3 +2,18 @@
   [There should be 2 PerformanceEntries]
     expected: FAIL
 
+  [secureConnectionStart and fetchStart should be the same]
+    expected: FAIL
+
+  [domainLookupEnd and fetchStart should be the same]
+    expected: FAIL
+
+  [connectStart and fetchStart should be the same]
+    expected: FAIL
+
+  [domainLookupStart and fetchStart should be the same]
+    expected: FAIL
+
+  [connectEnd and fetchStart should be the same]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/resource-timing/resource_dedicated_worker.html.ini b/tests/wpt/metadata/resource-timing/resource_dedicated_worker.html.ini
diff --git a/tests/wpt/metadata/resource-timing/test_resource_timing.html.ini b/tests/wpt/metadata/resource-timing/test_resource_timing.html.ini
@@ -15,9 +15,6 @@
   [PerformanceEntry has correct protocol attribute (iframe)]
     expected: FAIL
 
-  [window.performance.getEntriesByName() and window.performance.getEntriesByNameType() return same data (img)]
-    expected: FAIL
-
   [PerformanceEntry has correct name, initiatorType, startTime, and duration (img)]
     expected: FAIL
 
diff --git a/tests/wpt/metadata/resource-timing/test_resource_timing.https.html.ini b/tests/wpt/metadata/resource-timing/test_resource_timing.https.html.ini
@@ -51,9 +51,6 @@
   [PerformanceEntry has correct protocol attribute (xmlhttprequest)]
     expected: FAIL
 
-  [window.performance.getEntriesByName() and window.performance.getEntriesByNameType() return same data (img)]
-    expected: FAIL
-
   [PerformanceEntry has correct order of timing attributes (script)]
     expected: FAIL
 
diff --git a/tests/wpt/metadata/workers/worker-performance.worker.js.ini b/tests/wpt/metadata/workers/worker-performance.worker.js.ini
@@ -18,3 +18,9 @@
   [performance.toJSON is available in workers]
     expected: FAIL
 
+  [performance.clearResourceTimings in workers]
+    expected: FAIL
+
+  [performance.setResourceTimingBufferSize in workers]
+    expected: FAIL
+
diff --git a/tests/wpt/mozilla/meta/MANIFEST.json b/tests/wpt/mozilla/meta/MANIFEST.json
@@ -21110,7 +21110,7 @@
    "support"
   ],
   "mozilla/xmlhttprequest_url.html": [
-   "e5d10f27c06e1febd3bb70f8f128194fc3f63861",
+   "3a765c1e45b0ff25d9161e70f2ad0718769a4cdb",
    "testharness"
   ]
  },
diff --git a/tests/wpt/mozilla/tests/mozilla/xmlhttprequest_url.html b/tests/wpt/mozilla/tests/mozilla/xmlhttprequest_url.html
@@ -19,7 +19,7 @@
 
   request.onload = t.step_func_done(function() {
     let entries = window.performance.getEntriesByType("resource");
-    assert_equals(entries.length, 1);
+    assert_equals(entries.length, 3);
     assert_equals(entries[0].name, href);
   });
 }, "Performance entries should contain the URL where the XMLHttpRequest originated");

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ pub fn submit_timing_data(`
`62`	`62`	`PerformanceResourceTiming::new(global, url, initiator_type, None, resource_timing);`
`63`	`63`	`global`
`64`	`64`	`.performance()`
`65`		`- .queue_entry(performance_entry.upcast::<PerformanceEntry>(), false);`
	`65`	`+ .queue_entry(performance_entry.upcast::<PerformanceEntry>(), true);`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`impl<Listener: PreInvoke + Send + 'static> NetworkListener<Listener> {`