Fix homebrew analytics directory for brew 1.0#486
Conversation
|
Well, that fixed the crash, but the two OSX builds still hit: |
|
IMO #483 is a better fix, but currently hitting the same problems. Since they work in different ways, I think this may be an intermittent issue with Travis ATM. |
|
That being said, I am OK with landing this as a quicker-fix in the meantime if it starts working, but we need to be careful about upgrading Homebrew (to >= 1.0.0) on all of our Mac builders so this state works properly. |
|
Aha! I didn't see #483 for some reason and apologize. Would you rather land that one? I'm happy to close this and manually-land that one instead. |
|
Well, #483 is untested code I worked on at 3 AM, so I don't trust it one bit until it passes Travis. If you want to land something right now, I'd feel comfortable hand-merging this PR, although we'll need to keep landing manually until the issue gets fixed. We just need to upgrade Homebrew on all the Macs for this one. (Also, don't forget that with gitfs manual deploys have a different process now.) |
|
Sounds good - thanks! Then I'll merge this (to unblock the other PR for osmesa-src), and hopefully we can look more at #483 once things are less of a hot mess on macOS for travis. |
|
I just realized we could have just merged the osmesa-src PR directly, since this one is also broken... |
r? @aneeshusa @edunham
Homebrew in version 1.0 has moved their git repository to
/usr/local/Homebrewto avoid the various problems with Apple fooling around with/usr/local. See Homebrew/install#60Note that I believe we could also set
HOMEBREW_DISABLE_ANALYTICS=1, but there's a risk that anybrewcommand not done with that set would still perform analytics reporting.This bug is currently preventing us from landing other saltfs changes. See #484
This change is