Revert "Reimplement idna on top of ICU4X (#923)"#942
Closed
valenting wants to merge 0 commit intoservo:mainfrom
Closed
Revert "Reimplement idna on top of ICU4X (#923)"#942valenting wants to merge 0 commit intoservo:mainfrom
valenting wants to merge 0 commit intoservo:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
=======================================
Coverage ? 81.76%
=======================================
Files ? 21
Lines ? 3549
Branches ? 0
=======================================
Hits ? 2902
Misses ? 647
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Contributor
|
Might be easier to only revert the url -> idna dependency to 0.5 for now? |
Collaborator
Author
Line 29 in 3d6dbbb idna = { version = "1.0.0", path = "../idna" }That might be a better idea, but we'd have to stop referring dependencies by path. 🤔 |
Manishearth
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3d6dbbb.
See #937 for reasons behind this backout.