Fix search setting for non-special urls with space, query and fragment (#879)

edgul · web-flow · commit 67fc2730b658 · 2023-11-09T15:28:18.000Z
diff --git a/url/src/lib.rs b/url/src/lib.rs
@@ -1566,7 +1566,9 @@ impl Url {
             });
         } else {
             self.query_start = None;
-            self.strip_trailing_spaces_from_opaque_path();
+            if fragment.is_none() {
+                self.strip_trailing_spaces_from_opaque_path();
+            }
         }
 
         self.restore_already_parsed_fragment(fragment);
diff --git a/url/tests/expected_failures.txt b/url/tests/expected_failures.txt
@@ -42,12 +42,10 @@
 <foo:///some/path> set pathname to <>
 <http://example.net:8080/path> set port to <randomstring>
 <file:///var/log/system.log> set href to <http://0300.168.0xF0>
-<data:space  ?query#fragment> set search to <>
-<sc:space  ?query#fragment> set search to <>
 <file://monkey/> set pathname to <\\\\>
 <file:///unicorn> set pathname to <//\\/>
 <file:///unicorn> set pathname to <//monkey/..//>
 <non-spec:/> set pathname to </.//p>
 <non-spec:/> set pathname to </..//p>
 <non-spec:/> set pathname to <//p>
-<non-spec:/.//> set pathname to <p>
+<non-spec:/.//> set pathname to <p>
