Skip to content

Release a version 0.6.1 of harfbuzz and consolidate Cargo configuration#253

Merged
mrobinson merged 1 commit intomainfrom
increase-version
Apr 23, 2024
Merged

Release a version 0.6.1 of harfbuzz and consolidate Cargo configuration#253
mrobinson merged 1 commit intomainfrom
increase-version

Conversation

@mrobinson
Copy link
Member

I managed to publish this crate without checking out the git submodules
first, which breaks the bundled build. This version bump will ensure
that the latest version on crates.io can build.

@mrobinson mrobinson changed the title Release a new version of all crates Release a version 0.6.1 of all crates Apr 12, 2024
@mrobinson mrobinson requested a review from mrego April 12, 2024 12:17
@waywardmonkeys
Copy link
Collaborator

There's no need to bump the version for harfbuzz-traits ... Part of the point of that crate is that the version needn't change as often.

cc: @Manishearth @sffc

@mrobinson
Copy link
Member Author

Some projects seems to use workspace versioning, which I think can make things a lot easier to understand for people using these crates. Here's an example: https://github.com/emilk/egui/blob/master/Cargo.toml#L23 As a person who has to upgrade a lot of dependencies, I find this easier to deal with. It's always clear what the latest version of the crate is.

@mrobinson
Copy link
Member Author

I have updated this change to explicitly use workspace versioning, which should simplify new releases.

@waywardmonkeys
Copy link
Collaborator

That is worse.

harfbuzz-traits is meant to not change version except when absolutely necessary (a trait is added / removed / changed). That's why it exists rather than just having people use harfbuzz or harfbuzz-sys to get those traits.

keywords = { workspace = true }
license = { workspace = true }
repository = { workspace = true }
version = { workspace = true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't inherit, yes?

@Manishearth
Copy link
Member

Yeah I'm not sure if we should use workspace versioning. Everything else, yes.

…uration

I managed to publish this crate without checking out the git submodules
first, which breaks the `bundled` build. This version bump will ensure
that the latest version on crates.io can build.
@mrobinson mrobinson changed the title Release a version 0.6.1 of all crates Release a version 0.6.1 of harfbuzz and consolidate Cargo configuration Apr 23, 2024
@mrobinson mrobinson added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 1fe061e Apr 23, 2024
@mrobinson mrobinson deleted the increase-version branch April 23, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants