Re-enable improper_ctypes lint on bindings and update CI#73
Merged
mrobinson merged 2 commits intoservo:mainfrom Apr 23, 2024
Merged
Re-enable improper_ctypes lint on bindings and update CI#73mrobinson merged 2 commits intoservo:mainfrom
mrobinson merged 2 commits intoservo:mainfrom
Conversation
The linked issue rust-lang/rust#34798 has since been fixed, and rust will not warn if PhantomData is used in FFI structs. See also: rust-lang/rust#39462
Fixes warnings on github actions about updating to Node v20 by updating the used actions. actions-rs/toolchain is not maintained anymore, switch to dtolnay/rust-toolchain instead.
mrobinson
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for details.