Parse 'attr' as a function with 'var' and 'env'#415
Closed
DCR194 wants to merge 1 commit intoservo:mainfrom
Closed
Parse 'attr' as a function with 'var' and 'env'#415DCR194 wants to merge 1 commit intoservo:mainfrom
DCR194 wants to merge 1 commit intoservo:mainfrom
Conversation
emilio
requested changes
Nov 8, 2025
Member
emilio
left a comment
There was a problem hiding this comment.
So... conceptually this looks fine, but at the very least we should rename look_for_var_or_env_functions in parser.rs too. Probably we should rename it to look_for_arbitrary_substitution_functions, which is the CSS-values concept: https://drafts.csswg.org/css-values-5/#arbitrary-substitution
That said, I don't think this quite works, you need attr() to be configurable at runtime, right? Otherwise you can't put attr() behind a pref, and that's a bit annoying because we want it to be behind a pref.
So maybe we should do something along the lines of #416, wdyt?
Member
|
(The prefability aspect was not an issue with |
Author
|
I think that's great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I was hoping to merge this to add support for css attr functions. There is also some renaming for consistency. Let me know if there's anything I should change :)