Merged
Conversation
- Use xml5ever version of time! macro - Replace mac::unwrap_or_return with version from html5ever
Signed-off-by: Nico Burns <nico@nicoburns.com>
mrobinson
reviewed
Jun 30, 2025
Signed-off-by: Nico Burns <nico@nicoburns.com>
mrobinson
approved these changes
Jun 30, 2025
Signed-off-by: Nico Burns <nico@nicoburns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an old/unmaintained crate (no commit or release since 2017) which doesn't provide much value today due to improvements to the language / stdlib:
format_ifmacro with manual if..else (which IMO is clearer and is no longer)test_eqmacro with plain test functionsunwrap_or_returnmacro with copy of macro which already existed inhtml5ever(duplicate toxml5ever)time!macros inxml5everto match one inhtml5ever. These macros were slightly different but I believe equivalent in functionality (looks like thehtml5everversion was created beforeInstant::as_nanos()existed in the stdlib)