fix: restore two-runner lipo matrix for macOS universal binary#31
Merged
fix: restore two-runner lipo matrix for macOS universal binary#31
Conversation
Homebrew OpenSSL is single-arch (native only). CMAKE_OSX_ARCHITECTURES fails to link x86_64 when OpenSSL is arm64-only. Revert to the proven two-runner matrix (arm64 + x86_64) with lipo merge for universal binary. Each runner builds for its native arch with native-arch OpenSSL, then the package-macos job merges all Mach-O binaries with lipo.
Contributor
Build Artifacts
Built from bf4173c. Artifacts expire after 90 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMAKE_OSX_ARCHITECTURES="arm64;x86_64"fails because Homebrew OpenSSL is single-arch (native only per runner)package-macosjob merges with lipoWhat broke
The v1.7.1 release build failed with:
Test plan