Skip to content

fix: use env var to check VT_API_KEY instead of secrets in if condition#18

Merged
yani- merged 1 commit intomasterfrom
fix/release-vt-condition
Mar 28, 2026
Merged

fix: use env var to check VT_API_KEY instead of secrets in if condition#18
yani- merged 1 commit intomasterfrom
fix/release-vt-condition

Conversation

@yani-
Copy link
Copy Markdown
Member

@yani- yani- commented Mar 28, 2026

Summary

  • Fix broken release workflow caused by if: secrets.VT_API_KEY != ''
  • GitHub Actions doesn't allow secrets context in if conditions, causing the workflow parser to reject the entire file
  • Replace with a setup step that sets HAS_VT_KEY=true env var, then check if: env.HAS_VT_KEY == 'true'

Test plan

  • After merge, re-run the v1.6.0 release workflow via gh workflow run release.yml

GitHub Actions does not allow referencing secrets in step-level `if`
conditions. The workflow parser rejects the entire file, causing all
release builds to fail with "workflow file issue".
@github-actions github-actions bot added the ci CI/CD workflows label Mar 28, 2026
@yani- yani- merged commit baa992a into master Mar 28, 2026
6 checks passed
@yani- yani- deleted the fix/release-vt-condition branch March 28, 2026 06:11
@github-actions
Copy link
Copy Markdown
Contributor

Build Artifacts

Platform Download
Linux (x86_64) Traktor-linux-x86_64
macOS (Apple Silicon) Traktor-macOS
Windows (x64) Traktor-windows-x64

Built from 843a7cb. Artifacts expire after 90 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant