Handle existing extraction directory instead of failing silently#11
Merged
borislav-angelov merged 2 commits intomasterfrom Mar 27, 2026
Merged
Handle existing extraction directory instead of failing silently#11borislav-angelov merged 2 commits intomasterfrom
borislav-angelov merged 2 commits intomasterfrom
Conversation
When the target extraction directory already exists, QDir::mkdir() returns false and shows a misleading "Fix permissions" error. Now shows a dialog with three options: - Wipe & Extract: removes existing directory and proceeds - Create New Folder: appends (1), (2), etc. to find an available name - Cancel: aborts extraction
… directory suffix to 100 Assign QFileDialog result to a local variable before checking for cancel, so backupFilename is preserved when the user cancels the open dialog after a drag-and-drop. Also cap the "Create New Folder" suffix loop at 100.
borislav-angelov
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the target extraction directory already exists, QDir::mkdir() returns false and shows a misleading "Fix permissions" error.
Now shows a dialog with three options: