Set DefaultMode for projected ProjectedVolumeSource#413
Merged
scothis merged 1 commit intoservicebinding:mainfrom May 14, 2024
Merged
Set DefaultMode for projected ProjectedVolumeSource#413scothis merged 1 commit intoservicebinding:mainfrom
scothis merged 1 commit intoservicebinding:mainfrom
Conversation
This value is set server side for many resources, we can avoid churn by setting it directly ourselves. 0644 is the default-default value. Signed-off-by: Scott Andrews <scott@andrews.me>
Member
Author
|
Keeping as draft because I want to further dig into the root cause of the reported issue to see if there is a more fundamental issue that we shouldn't paper over. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
+ Coverage 78.43% 78.45% +0.01%
==========================================
Files 19 19
Lines 1354 1355 +1
==========================================
+ Hits 1062 1063 +1
Misses 219 219
Partials 73 73 ☔ View full report in Codecov by Sentry. |
|
Hi @scothis, do you have any news about this issue? Thanks |
Member
Author
|
@sandrotaje sorry for the delay. Merged this and released as v0.9.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This value is set server side for many resources, we can avoid churn by setting it directly ourselves. 0644 is the default-default value.
Resolves #411