Support configure election timeouts#382
Merged
nebhale merged 1 commit intoservicebinding:mainfrom Jan 30, 2024
Merged
Conversation
Signed-off-by: Chunyi Lyu <clyu@vmware.com>
210ec39 to
abd8ef3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
=======================================
Coverage 77.75% 77.75%
=======================================
Files 19 19
Lines 1699 1699
=======================================
Hits 1321 1321
Misses 305 305
Partials 73 73 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support so users can configure leader election related timeouts through command flags.
Default lease duration is 15s and renew deadline is 10s. However in certain environments with lots of controller pods it might longer occasionally. Defaults for them stay the same as before, and this PR only adds a way to configure them if users want to.