Skip to content

Restore v1alpha3 API support#334

Merged
scothis merged 1 commit intoservicebinding:mainfrom
scothis:conversion
Sep 12, 2023
Merged

Restore v1alpha3 API support#334
scothis merged 1 commit intoservicebinding:mainfrom
scothis:conversion

Conversation

@scothis
Copy link
Member

@scothis scothis commented Sep 7, 2023 •
edited
Loading

Implement conversion interfaces between v1beta1 and v1alpha3, and install validation webhooks for v1alpha3 requests. The v1alpha3 API is now implemented in terms of v1beta3 types to avoid duplication of business logic.

Resolves #333

@scothis scothis requested a review from a team September 7, 2023 16:44
@scothis
Copy link
Member Author

scothis commented Sep 7, 2023

@ChunyiLyu does this fix your issue?

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.12% ⚠️

Comparison is base (d185b32) 81.53% compared to head (2fe49c7) 81.42%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   81.53%   81.42%   -0.12%     
==========================================
  Files          15       17       +2     
  Lines        1446     1448       +2     
==========================================
  Hits         1179     1179              
- Misses        219      221       +2     
  Partials       48       48
Files Changed Coverage Δ
...beta1/clusterworkloadresourcemapping_conversion.go 0.00% <0.00%> (ø)
.../v1beta1/clusterworkloadresourcemapping_webhook.go 96.33% <ø> (ø)
apis/v1beta1/servicebinding_conversion.go 0.00% <0.00%> (ø)
apis/v1beta1/servicebinding_webhook.go 94.87% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scothis scothis force-pushed the conversion branch 2 times, most recently from 2fe49c7 to aa5ea2d Compare September 7, 2023 17:24
@scothis
Restore v1alpha3 API support
f3b8318 
Implement conversion interfaces between v1beta1 and v1alpha3, and
install validation webhooks for v1alpha3 requests. The v1alpha3 API is
now implemented in terms of v1beta3 types to avoid duplication of
business logic.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@ChunyiLyu
Copy link
Contributor

ChunyiLyu commented Sep 8, 2023

@scothis Thanks for the quick fix. I tested with the samples/spring-petclinic example. I can create and delete the following binding:

---
apiVersion: servicebinding.io/v1alpha3
kind: ServiceBinding
metadata:
  name: spring-petclinic-db
  annotations:
    kapp.k14s.io/change-group: binding
    kapp.k14s.io/change-rule.service: "upsert after upserting service"
    kapp.k14s.io/change-rule.service-delete: "delete before deleting service"
    kapp.k14s.io/change-rule.workload: "upsert before upserting workload"
    kapp.k14s.io/change-rule.workload-delete: "delete after deleting workload"
spec:
  # direct Secret reference is used for compatibility, but not recommended for dynamically provisioned services
  service:
    apiVersion: v1
    kind: Secret
    name: spring-petclinic-db
  workload:
    apiVersion: apps/v1
    kind: Deployment
    name: spring-petclinic

st3v
st3v reviewed Sep 8, 2023
View reviewed changes
config/crd/bases/servicebinding.io_clusterworkloadresourcemappings.yaml
Copy link

@st3v st3v Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Did you intentionally drop annotations and volumes from the list of required properties here?

Copy link
Member Author

@scothis scothis Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't intentional, but the change is also correct as it aligns with the v1beta1 api. The values are defaulted, so requiring them isn't necessary.

@scothis scothis merged commit 622ccfb into servicebinding:main Sep 12, 2023
@scothis scothis deleted the conversion branch September 12, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sadlerap sadlerap sadlerap approved these changes

+1 more reviewer

@st3v st3v st3v left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

servicebinding.io/v1alpha3 not supported

5 participants

@scothis @codecov-commenter @ChunyiLyu @st3v @sadlerap