Skip to content

ci: upload test results as an artifact#293

Merged
scothis merged 2 commits intoservicebinding:mainfrom
sadlerap:save-test-results
Jun 12, 2023
Merged

ci: upload test results as an artifact#293
scothis merged 2 commits intoservicebinding:mainfrom
sadlerap:save-test-results

Conversation

@sadlerap
Copy link
Contributor

@sadlerap sadlerap commented Jun 6, 2023

Since we run tests in parallel, behavex doesn't output a lot to the console. To retain some sense of ability to debug testing failures in CI, we should upload the output of behavex as an artifact to be inspected.

@scothis
Copy link
Member

scothis commented Jun 6, 2023

As discussion on the working group call. We need to make sure the output artifact is capture for each test run (it's currently overwriting). Another option is to dump the logs to the console in the diagnostics step.

@sadlerap sadlerap force-pushed the save-test-results branch from fcfbf90 to fe933d4 Compare June 6, 2023 16:12
@scothis
Copy link
Member

scothis commented Jun 12, 2023

Not required for this PR, but using something like https://github.com/marketplace/actions/junit-report-action could make the test reports more accessible without downloading the zip

@scothis
Copy link
Member

scothis commented Jun 12, 2023

This PR was useful to uncover servicebinding/conformance#59

@scothis
Copy link
Member

scothis commented Jun 12, 2023

@sadlerap can we merge this?

Since we run tests in parallel, behavex doesn't output a lot to the
console.  To retain some sense of ability to debug testing failures in
CI, we should upload the output of behavex as an artifact to be
inspected.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@sadlerap sadlerap force-pushed the save-test-results branch from fe933d4 to 92583bd Compare June 12, 2023 19:33
@sadlerap sadlerap marked this pull request as ready for review June 12, 2023 19:33
@sadlerap
Copy link
Contributor Author

@scothis Should be good to merge at this point IMO, unless you have any particular reason to hold up on this.

Signed-off-by: Scott Andrews <scott@andrews.me>
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (748e4c2) 81.53% compared to head (2e76a52) 81.53%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   81.53%   81.53%           
=======================================
  Files          15       15           
  Lines        1446     1446           
=======================================
  Hits         1179     1179           
  Misses        219      219           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scothis scothis merged commit 6a34f73 into servicebinding:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants