Default KO_PLATFORMS to only the current arch when kind is the target#244
Merged
scothis merged 1 commit intoservicebinding:mainfrom Feb 23, 2023
Merged
Default KO_PLATFORMS to only the current arch when kind is the target#244scothis merged 1 commit intoservicebinding:mainfrom
scothis merged 1 commit intoservicebinding:mainfrom
Conversation
ko has special behavior for a `KO_DOCKER_REPO` value of `kind.local`, it will load the images directly into the daemon rather than a registry. Kind clusters do not support multi-arch images, we should assume by default that the kind cluster is running on the same arch as the host. A user may continue to override the default by setting `KO_PLATFORMS` with the value they want to use at runtime. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov ReportBase: 81.80% // Head: 81.80% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage 81.80% 81.80%
=======================================
Files 15 15
Lines 1451 1451
=======================================
Hits 1187 1187
Misses 217 217
Partials 47 47 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
baijum
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ko has special behavior for a
KO_DOCKER_REPOvalue ofkind.local, it will load the images directly into the daemon rather than a registry. Kind clusters do not support multi-arch images, we should assume by default that the kind cluster is running on the same arch as the host.A user may continue to override the default by setting
KO_PLATFORMSwith the value they want to use at runtime.