Unproject using the same mapping used to project the binding#233
Merged
sadlerap merged 1 commit intoservicebinding:mainfrom Feb 6, 2023
Merged
Unproject using the same mapping used to project the binding#233sadlerap merged 1 commit intoservicebinding:mainfrom
sadlerap merged 1 commit intoservicebinding:mainfrom
Conversation
Codecov ReportBase: 82.66% // Head: 81.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
- Coverage 82.66% 81.71% -0.95%
==========================================
Files 15 15
Lines 1350 1444 +94
==========================================
+ Hits 1116 1180 +64
- Misses 200 217 +17
- Partials 34 47 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
From the spec: > When a service binding projection is removed, the controller MUST use > the same mappings from the projection creation. After a > ClusterWorkloadResourceMapping resource is modified, each binding > targeting the mapped workload type MUST be removed, then reattempted > with the latest mapping. We now stash the mapping used to project the binding on the workload as an annotation. When unprojecting that same binding, we use the stashed mapping to unproject the binding. If updating an existing binding, the stashed mapping is used to cleanup existing state before the updated mapping is used to re-project the binding into the workload. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
25e2090 to
ec9f81a
Compare
sadlerap
reviewed
Jan 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the spec:
We now stash the mapping used to project the binding on the workload as an annotation. When unprojecting that same binding, we use the stashed mapping to unproject the binding. If updating an existing binding, the stashed mapping is used to cleanup existing state before the updated mapping is used to re-project the binding into the workload.
Resolves #138