Update k8s, controller-runtime, reconciler-runtime and dies#227
Update k8s, controller-runtime, reconciler-runtime and dies#227scothis merged 1 commit intoservicebinding:mainfrom
Conversation
Breaking changes in k8s and controller-runtime require updating each component in lock step. The only change that directly affects us is that the fake api client now properly supports list requests using a field index. Previously, the response would ignore the field index and return all resources. The request is rejected unless the index is defined on the fake client, so we now define the index for test cases that use field indexed requests. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
|
@sadlerap looks like a conformance test flake https://github.com/servicebinding/runtime/actions/runs/3839334386/jobs/6537037419#step:14:983 |
|
The error appears to be My hypothesis for this is that To workaround this, we could batch assertion steps and do only one read from the workload. Less calls to the workload is less opportunities for flakiness. Alternatively, we could ditch the |
Breaking changes in k8s and controller-runtime require updating each component in lock step.
The only change that directly affects us is that the fake api client now properly supports list requests using a field index. Previously, the response would ignore the field index and return all resources. The request is rejected unless the index is defined on the fake client, so we now define the index for test cases that use field indexed requests.
Signed-off-by: Scott Andrews andrewssc@vmware.com