Conversation
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
sadlerap
left a comment
There was a problem hiding this comment.
LGTM, provided CI passes.
|
Good news: CI passed We should look at parallelizing the conformance tests, there's no reason they need to be sequential (other than the logs are easier to follow) |
|
Spoke too soon. There's a flaky test that failed in the push that passed in the PR build https://github.com/scothis/service-binding-controller/actions/runs/3652073282/jobs/6170243394 |
|
Hmmmm, not sure I like flakiness in these tests. Looking in the logs, there seem to be a bunch of errors getting reported (such as this one on the failing test); are those intentional? I've filed an issue for tracking performace problems; there's definitely some improvements that can be made. 1hr runtime for conformance tests aren't great. |
|
I see two common errors, both benign:
Was there another error you were seeing? |
|
nope, I wasn't sure if those were intentional or not, sorry for the confusion. |
Signed-off-by: Scott Andrews andrewssc@vmware.com