Ensure test-app deployments have unique labels per scenario#74
Merged
scothis merged 1 commit intoservicebinding:mainfrom Oct 12, 2023
Merged
Ensure test-app deployments have unique labels per scenario#74scothis merged 1 commit intoservicebinding:mainfrom
scothis merged 1 commit intoservicebinding:mainfrom
Conversation
Previously, since every deployment of the generic test app had the same label, the services we would make as a part of testing would forward requests to any running deployment since they could match the label selector. Make them unique, so that requests get forwarded to the correct pod. Signed-off-by: Andy Sadler <ansadler@redhat.com>
Contributor
Author
|
This should fix #64. |
Contributor
Author
|
The one test that's failing is an upstream bug which is in the process of being fixed. |
Member
|
Validated to work with servicebinding/runtime#348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, since every deployment of the generic test app had the same label, the services we would make as a part of testing would forward requests to any running deployment since they could match the label selector. Make them unique, so that requests get forwarded to the correct pod.