Skip to content

valve.source.a2s - BaseQuerier bug fixed#73

Merged
Yepoleb merged 1 commit intoserverstf:masterfrom
p5-vbnekit:valve.source.a2s-fix
Mar 13, 2019
Merged

valve.source.a2s - BaseQuerier bug fixed#73
Yepoleb merged 1 commit intoserverstf:masterfrom
p5-vbnekit:valve.source.a2s-fix

Conversation

@p5-vbnekit
Copy link
Copy Markdown
Contributor

Hi! This is my little fix. =)

  import valve.source.master_server
  import valve.source.a2s

  with valve.source.master_server.MasterServerQuerier() as m_msq:
    m_servers = m_msq.find(
        region=("eu", ),
        duplicates="skip",
        gamedir="cstrike",
        map="de_dust2",
    )

    for m_host, m_port in m_servers:
      with valve.source.a2s.ServerQuerier((m_host, m_port)) as m_query: m_query.rules()

sometimes we have:

Traceback (most recent call last):
  File "show-me-bug.py", line 17, in <module>
    with valve.source.a2s.ServerQuerier((m_host, m_port)) as m_query: m_query.rules()
  File "/usr/local/lib/python3.7/dist-packages/valve/source/a2s.py", line 228, in rules
    return messages.RulesResponse.decode(self.get_response())
  File "/usr/local/lib/python3.7/dist-packages/valve/source/a2s.py", line 52, in get_response
    data = BaseQuerier.get_response(self)
NameError: name 'BaseQuerier' is not defined

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 70.24% when pulling f7da20d on p5-vbnekit:valve.source.a2s-fix into 479768a on serverstf:master.

@Yepoleb
Copy link
Copy Markdown
Member

Yepoleb commented Mar 13, 2019

Thanks!

@Yepoleb Yepoleb merged commit 078d51a into serverstf:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants