Recognize command extensions from plugins and validate CLI input against result commands schema #9171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9171 +/- ##
==========================================
+ Coverage 86.93% 87.14% +0.21%
==========================================
Files 302 304 +2
Lines 11368 11462 +94
==========================================
+ Hits 9883 9989 +106
+ Misses 1485 1473 -12
Continue to review full report at Codecov.
|
fd850ea to
11db074
Compare
It ensures that also plugins added externally by invoking `pluginManager.addPlugin` are recognized as external. e.g. such practise can be observed here: https://github.com/serverless/serverless-azure-functions/blob/c53f535204c467339e8ae1f6edb985c3280bc32c/src/index.ts
It's needed to be able to process commands as introduced by plugins without a need of processing Serverless instance
11db074 to
19135d1
Compare
pgrzesik
approved these changes
Mar 24, 2021
Contributor
pgrzesik
left a comment
There was a problem hiding this comment.
Looks good - nothing to add 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalizes 4.0.0 & 5.1.0 from #8364
lifecycleEventsconfiguration to config schema, as it's crucial in detecting which AWS provider commands were adapted in context of other provider (note in such cases other provider doesn't have to configure command explicitly, it's enough that it attaches some function to pre-configured command lifecycle events)optvariable source (after having all commands schema resolved, last resolution phase was configured to resolve any final properties behindoptsources)