New variables engine #8987
Merged
New variables engine #8987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb7c95f to
5b88695
Compare
Codecov Report
@@ Coverage Diff @@
## master #8987 +/- ##
==========================================
+ Coverage 86.31% 86.96% +0.64%
==========================================
Files 274 283 +9
Lines 10247 10839 +592
==========================================
+ Hits 8845 9426 +581
- Misses 1402 1413 +11
Continue to review full report at Codecov.
|
ad3352d to
dfef0c6
Compare
dfef0c6 to
44d588f
Compare
20 tasks
This was referenced Mar 3, 2021
|
Great work :) |
Contributor
Author
|
Thank you @saumilsdk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 2.2.0 from #8364 and major part of #7207
self,opt,env,strToBoolandfile.envfilesvariables-legacy, and introduce newvariablesfixtureI mark it more as enhancement than refactor, as it's not a 1:1 refactor, but vastly improved resolution logic which changed how some edge cases are handled (e.g. we will no longer support
self:variable, and there's built-in reliable prevention of circular references). Additionally it fixes many reported bugs, which were more design bugs of so currently implemented resolverFixes: #7921, #7807, #6214, #6022, #6014, #5828, #5759, #5278, #5136, #4837, #4817
Additionally
@serverless/testwas updated to rely on new resolver: https://github.com/serverless/test/pull/82