fix makeDeepVariable replacement #5809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #5807
How did you implement it:
5ed78b8 added preservation of white space in a single-quote literal. This caused
makeDeepVariableto not replace thevariableStringproperly with thedeep:0syntax because white space was only being removed from the variableContainer.To fix I just added the removal of white space from
variableStringas well.How can we verify it:
I added a new test for the case for it. The sample in #5807 works as well now.
Todos:
Is this ready for review?: NO
Is it a breaking change?: NO