Re-write self:service.[...] to self:serviceObject.[...]
#4859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle `self:service.[...]` references properly. The prior represents what the user typed into their configuration. In service, we move all this from `service` to `serviceObject`, therefore, by rewriting `self:service.[...]` to `self:serviceObject.[...]` user's will get the result they expect. Use else if, given exclusivity of conditions
HyperBrain
approved these changes
Mar 28, 2018
Contributor
HyperBrain
left a comment
There was a problem hiding this comment.
Looks good from my side regarding the change.
As soon as we have a confirmation that it actually fully resolves the problem, we can merge it
Contributor
|
Works like a charm! Thanks @erikerikson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Fixes reported issue on #4754 by @dschep
Handle
self:service.[...]references properly. The prior represents what the user typed into their configuration. In service, we move all this fromservicetoserviceObject, therefore, by rewritingself:service.[...]toself:serviceObject.[...]user's will get the result they expect.Cleanup: use
else if, given exclusivity of conditionsHow did you implement it:
filter
self:service.variables, replacing that part withself:serviceObject.to avoid failed resolutions.How can we verify it:
Run the offered test.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO