fix(deps): bump fast-xml-parser to 5.5.6 for GHSA-8gc5-j5rx-235r#13412
Merged
fix(deps): bump fast-xml-parser to 5.5.6 for GHSA-8gc5-j5rx-235r#13412
Conversation
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (13)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Made-with: Cursor
b4ecfd0 to
14d6667
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@aws-sdk/xml-builderfrom 3.972.9 to 3.972.13 across 13 lockfiles, which upgradesfast-xml-parserfrom 5.4.1 to 5.5.6Root cause
@aws-sdk/xml-builderpinnedfast-xml-parserto exactly 5.4.1, which is vulnerable to numeric entity expansion DoS (all versions through 5.5.5 are affected). AWS published@aws-sdk/xml-builder@3.972.13which bumps tofast-xml-parser@5.5.6and also setsprocessEntities: { maxTotalExpansions: Infinity }to prevent the new expansion limit from breaking legitimate AWS XML responses.Test plan
npm installsucceeds cleanlynpm auditno longer reportsfast-xml-parservulnerabilities@aws-sdk/xml-builder@3.972.13+fast-xml-parser@5.5.6fast-xml-parser@5.5.6with the@aws-sdk/xml-builder@3.972.13parser config (300 CloudFormation events, 1500+ entity expansions) — noEntity expansion limit exceedederrorpackage-lock.jsonfiles changed — nopackage.jsonmodifications