chore(deps): upgrade Go to 1.26 in binary installer#13402
Conversation
|
Cursor Agent can help with this pull request. Just |
⛔ Snyk checks have failed. 2 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughGo requirement bumped from 1.25 to 1.26.1 in CI workflows and the binary-installer module file. No other behavioral or API changes introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fb56d60 to
04e4629
Compare
04e4629 to
02a37a4
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci-binary-installer.yml:
- Line 28: The GitHub Actions step using actions/setup-go currently sets
go-version: '>=1.26.1' which is an open-ended SemVer range; update the
go-version value to a bounded patch range (e.g., '~1.26.1') so it allows patch
updates but prevents automatic minor bumps (change go-version in the
actions/setup-go step from '>=1.26.1' to '~1.26.1').
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 54c7958e-d634-4524-a102-583f05890a02
📒 Files selected for processing (3)
.github/workflows/ci-binary-installer.yml.github/workflows/release-binary-installer.ymlbinary-installer/go.mod
Co-authored-by: tomasz.czubocha <tomasz.czubocha@gmail.com>
02a37a4 to
a16effd
Compare
Closes: #{ISSUE_NUMBER}
This PR upgrades the Go version used by the binary installer to
1.26.Why this change:
std/ospackage in older Go versions (e.g., 1.25.7) had a Directory Traversal vulnerability. Go 1.26.1 (and later patches) includes the fix.1.26ingo.modand>=1.26in CI/release workflows, the build system will automatically pick up the latest patch version of Go 1.26, ensuring continuous security updates without manual intervention.Summary by CodeRabbit