Skip to content

chore: remove redundant license fields from package.json files#13285

Merged
czubocha merged 1 commit intomainfrom
package-json-license
Jan 20, 2026
Merged

chore: remove redundant license fields from package.json files#13285
czubocha merged 1 commit intomainfrom
package-json-license

Conversation

@czubocha
Copy link
Copy Markdown
Contributor

@czubocha czubocha commented Jan 20, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Removed license metadata from package configuration files across the project.

Note: This is an internal configuration update with no impact on functionality or user experience.

✏️ Tip: You can customize this high-level summary in your review settings.

@czubocha czubocha requested a review from eahefnawy January 20, 2026 20:32
@Mmarzex
Copy link
Copy Markdown
Contributor

Mmarzex commented Jan 20, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 20, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The PR removes the license field from 16 package.json files across the repository, including the root package.json, core framework packages, and test fixture configurations. No functional code or dependencies are affected.

Changes

Cohort / File(s) Summary
Root and core packages
package.json, packages/framework-dist/package.json, packages/sf-core-installer/package.json, packages/sf-core/package.json		 Removed license field (either empty string or "ISC" value) from package metadata
Engine integration fixtures
packages/engine/integration/e2e/fixture/service/package.json		 Removed license: "ISC" field
Test fixtures
packages/sf-core/tests/python/tests/*/package.json (base, individually, individually\_mixed\_runtime, non\_build\_pyproject, non\_poetry\_pyproject, pipenv, poetry, poetry\_individually, poetry\_packages, scaleway\_provider)		 Removed license: "ISC" field while preserving author field in each test package.json

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 With whiskers twitched and nose held high,
I hopped through JSON, field by field with a sigh,
Each license removed, a config so light,
Sixteen files cleaner—metadata done right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove redundant license fields from package.json files' accurately and clearly summarizes the main change: removing license fields across multiple package.json files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@czubocha czubocha merged commit 1647d57 into main Jan 20, 2026
14 checks passed
@czubocha czubocha deleted the package-json-license branch January 20, 2026 20:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eahefnawy eahefnawy eahefnawy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@czubocha @Mmarzex @eahefnawy