Skip to content

Add validation for conflicting version configurations#23

Merged
afuno merged 3 commits intomainfrom
feature/new_conflicts
Nov 19, 2025
Merged

Add validation for conflicting version configurations#23
afuno merged 3 commits intomainfrom
feature/new_conflicts

Conversation

@afuno
Copy link
Member

@afuno afuno commented Nov 19, 2025

No description provided.

- Introduced `VersionDefaultDeprecatedConflict` exception to catch cases where a version is marked as both default and deprecated.
- Added `VersionMultipleDefaults` exception to handle scenarios where multiple versions are declared as default.
- Updated `Factory` and `DSL` classes to enforce these validations during version definition.
- Enhanced controller rescue clauses to handle these new exceptions and provide meaningful error messages.
- Expanded documentation and troubleshooting guides to outline the causes, solutions, and best practices for resolving these errors.
@afuno afuno added this to the v1.0.0 milestone Nov 19, 2025
@afuno afuno self-assigned this Nov 19, 2025
@afuno afuno added the feature label Nov 19, 2025
- Removed unnecessary `.to_s` call on `@version.version` during interpolation.
- Ensured cleaner code and improved readability in `VersionDefaultDeprecatedConflict` exception handling.
@afuno afuno marked this pull request as ready for review November 19, 2025 18:59
- Deleted `ConflictsDefaultDeprecatedTreaty` and `ConflictsMultipleDefaultsTreaty` classes, as they are no longer required for validation testing.
- These cases are now covered by enhanced exception handling and validation mechanisms introduced in recent updates.
- Simplified the codebase by removing redundant treaty definitions.
@afuno afuno merged commit 132a402 into main Nov 19, 2025
19 checks passed
@afuno afuno deleted the feature/new_conflicts branch November 19, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant