Introduce unified Crate storage for Warehouse optimization #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Storage class with single instance holding all data sections - Refactor Inputs, Internals, Outputs to receive hash references - Remove inheritance from Base class in favor of composition - Simplify Setup by delegating to Storage - Add YARD documentation for all warehouse classes - Update RBS type signatures
- Restore inheritance from Base for Inputs, Internals, Outputs - Remove duplicated fetch/assign methods from subclasses - Use super() to initialize @arguments from Base - Simplify RBS signatures by inheriting from Base
- Move attr_reader to class top in Storage - Remove visual separator comments from Inputs
- Remove initialize that only calls super in Internals - Remove initialize that only calls super in Outputs - Update RBS signatures accordingly
- Rename storage.rb to crate.rb and Storage class to Crate - Update @storage instance variable to @crate in Setup - Improve YARD comments for better readability - Update RBS type signatures with new class name
- Simplify documentation by removing implementation details - Keep only Purpose sections that describe class functionality
- Complete documentation simplification across warehouse module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.