Replace dynamic singleton methods with instance methods in Result #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace dynamic singleton methods with instance flag @success - Add success?, failure?, error as regular instance methods - Convert Outputs class to use method_missing with hash storage - Add output_names and predicate_names introspection methods - Update factory methods to pass success state directly - Add comprehensive YARD documentation - Update RBS type signatures for new architecture
- Break long single-line conditional into multi-line if statement
- Update regex patterns to match new error message format - Ruby 3.4 uses "for an instance of Class" instead of "for #<Class"
- Update else branch to match new method_missing error format - Both Ruby 3.4+ and older versions now expect "for an instance of" format
- Revert else branch to use "#<Class" format for Ruby < 3.4 - Keep "for an instance of" format only for Ruby 3.4+
- Use "for an instance of" format for both Ruby 3.4+ and older versions - Aligns with method_missing behavior in refactored Result class
- Ruby 3.4+: single quotes, "for an instance of" format - Ruby 3.3.x: backticks, "for an instance of" format - Ruby < 3.3: backticks, "#<Class" format
- Ruby 3.4+: single quotes, "for an instance of" format - Ruby 3.3.x: backticks, "for an instance of" format - Ruby < 3.3: backticks, "#<Class" format
- Replace Rails-specific "params" with generic "arguments"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.