Enhance Collection and Runner with improved stage functionality #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced detailed examples: `Example14`, `Example15`, and `Example16` showcasing `stage`, `wrap_in`, `rollback`, and conditional logic usage. - Added associated RSpec tests to ensure example reliability. - Improved DSL functionality by refining `make` and `stage` logic. - Ensured actions are correctly added within or outside stage blocks. - Enhanced conditional check handling with `should_skip?`. - Added better rollback handling with `call_actions_with_rollback`. - Updated `Collection` API to include `size` and `empty?` delegation.
- Added detailed inline documentation for `Collection` and `Runner` classes, explaining their purpose, usage, and integration. - Updated `Collection` API with full documentation for delegated methods and the `sorted_by_position` method. - Enhanced `Runner` with extensive comments on action/condition handling, rollbacks, and exception handling logic. - Refined method names for clarity: - `unnecessary_for_stage?` -> `should_skip?` - `unnecessary_for_make?` -> removed (revised logic). - `prepare_condition_for` -> `condition_met?`. - Updated corresponding `.rbs` signatures to match new API changes and method documentation.
- Enhanced inline documentation for the `Runner` class to specify that the context includes `inputs`, `internals`, and `outputs`.
- Add inline Rubocop disable for Naming/MethodParameterName - Keep short parameter name `_e` for unused exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.