Improve dynamic options inclusion: Add Range support and refactor logic #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced inclusion submatchers and dynamic options to support `Range` values natively. - Improved handling of mixed inclusion formats (`Array`, `Range`) for better compatibility. - Refactored normalization and comparison logic for inclusion values. - Added methods to safely generate values outside inclusion constraints. - Updated RBS signatures to reflect changes in inclusion handling.
- Refactored conditional logic in `#valid?` method to streamline optional with default case handling. - Simplified `#normalize_inclusion_values` method by merging `Range` and `Array` checks for improved readability. - Minor consistency update in `description` method to standardize string formatting.
- Refactored conditional logic in inclusion validation methods for clarity, particularly handling of optional default cases. - Replaced `compare_inclusion_values` with more descriptive `inclusion_values_match?` for better expressiveness. - Updated RBS signatures and related submatchers to align with new method naming. - Reformatted lambda expressions with multiline syntax for improved code style consistency.
- Introduced `Example13` to `Example19` under `Usual::DynamicOptions::Inclusion` demonstrating various inclusion use cases (ranges, unlimited, and custom messages). - Added `Example7` under `Wrong::DynamicOptions::Inclusion` to showcase invalid inclusion behavior. - Provide comprehensive RSpec tests for all new examples, ensuring validation and boundary checks. - Maintained existing code patterns and best practices for consistency.
- Deleted `Example7` class and its associated RSpec tests under `Wrong::DynamicOptions::Inclusion`. - Code and tests for `Example7` showcased invalid inclusion behavior, which is no longer required. - Streamlined the codebase by removing unnecessary examples and tests.
…dation - Replaced `case` statement in `element_matches?` with a streamlined ternary operation for improved readability. - Added a `nil` check in `range_covers?` to prevent errors and ensure robust validation. - Maintained method behavior and compatibility with existing codebase patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.