Improve dynamic options validation: nil guards, stricter format checks, and Float precision fix #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `condition_for_*` methods to handle cases where `option.value` is nil, returning an invalid option status. - Enhanced `message_for_*` methods to support dynamic translation keys based on validation reasons. - Added new locale keys (`invalid_option`) to both English and Russian translation files to provide specific error messages for undefined `in` options.
- Updated regex patterns in `Format` to use `\A` and `\z` for stricter validation. - Enhanced `validate` method in `Format` with `wrong_type` error for non-string inputs. - Refactored `multiple_of` behavior to handle floating-point precision safely. - Replaced redundant class checks with generic `Numeric` type for better clarity. - Added new translation keys (`wrong_type`) in English and Russian locales for better error messaging.
- Introduced new examples under `Usual::DynamicOptions::MultipleOf` to validate floating-point divisors and internal assignments. - Added detailed `Wrong::DynamicOptions::Format::WrongType` examples, covering invalid types for inputs, internals, and outputs. - Expanded `Wrong::DynamicOptions::Inclusion` examples to handle nil and invalid `in` values across attributes. - Included comprehensive RSpec tests for each example to ensure edge-case handling and improved error messaging consistency. - Strengthened spec behavior expectations for invalid configurations and supported translations for error scenarios.
- Refactored error messages in `Wrong::DynamicOptions::Inclusion` to improve clarity and consistency for missing `inclusion` values. - Updated `message_for_*` methods to include `option_name` in error translations. - Adjusted English and Russian locale keys to provide better specificity for invalid options. - Enhanced related RSpec tests to verify updated error message content.
- Refined error messages for `invalid_option` across inputs, internals, and outputs to improve clarity. - Updated Russian locale phrasing to better reflect missing option values in dynamic options validation scenarios. - Ensured consistency in error messaging format across all attributes.
- Simplified `condition_for_*` methods in `Inclusion` by removing outdated RuboCop directives and improving code readability. - Enhanced comments for better understanding of condition logic. - Cleaned up trailing whitespace in `MultipleOf` spec examples for improved formatting and consistency. - Ensured all changes align with existing validation and error messaging improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.