Add information about stages and actions #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Changes: - Replaced all references to "methods" with "actions" for clarity. - Updated method definitions and variable names in `Runner` class: - `call_methods` -> `call_actions` - `call_method` -> `call_action` - `call_wrapper_with_methods` -> `call_wrapper_with_actions` - Adjusted the `Stage` class to replace `methods` with `actions`: - `next_method_position` -> `next_action_position` - `methods` -> `actions` - Updated corresponding changes in type signatures and `DSL` behavior. These refinements enhance alignment between class behavior and purpose.
### Changes: - Introduced `stages` attributes to both `Servactory::Info::Result` and `Servactory::Info::Builder`. - Extended `Builder` methods to handle `stages` during initialization and attribute construction. - Added `build_action_stages_with` method to process and map action stages. - Updated `Actions::Collection` and `Stages::Collection`: - Updated delegation methods to include `map` and `to_h`. - Renamed `methods` to `actions` in `Stages::Stage` for consistency. - Enhanced shared example specs to validate `stages` within `class info`. This update improves stage handling and aligns with the `actions` naming convention.
### Changes: - Extended the type signature of `Servactory::Info::Builder#initialize` to include a `collection_of_stages` parameter. - Updated builder logic to accommodate action stages for improved functionality and alignment with previous updates.
### Changes: - Removed the unused `next_action_position` method from the `Stage` class to clean up redundant code. - Updated type signature of `Actions::Stages::Collection#initialize` to accept optional `Set[Collection]` for improved flexibility. - Synchronized changes in related type definitions to maintain consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.