-
Notifications
You must be signed in to change notification settings - Fork 3
Add dynamic option target
#291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…features/SRV-248/type_class
…features/SRV-248/type_class
…features/SRV-248/type_class
…features/SRV-248/type_class
- Added `# rubocop:disable Naming/PredicateMethod` comments to methods in `Inclusion` and `Target` classes to suppress style warnings. - Ensured methods maintain clarity and functionality while adhering to project's style requirements.
Accept main's configuration architecture (Config + Configurable + dup_for_inheritance) and dynamic options validation improvements (nil guards, reason handling). Preserve feature branch's new `target` dynamic option implementation.
- Centralized inclusion value normalization into a new private method `normalize_inclusion_values`. - Updated multiple methods (`condition_for_input_with`, `condition_for_internal_with`, `condition_for_output_with`) to use normalized inclusion values for consistency. - Improved code readability and reduced duplication by reusing `normalize_inclusion_values`. - Added a safeguard to handle non-array option values gracefully by wrapping them in an array.
- Introduced a guard clause to handle `nil` values in dynamic option configurations for inputs, internals, and outputs. - Updated error messages to reflect missing values more clearly with a new `invalid_option` reason in both English and Russian locales. - Enhanced the `Target` toolkit with improved validation logic for dynamic options. - Added comprehensive RSpec coverage for all newly introduced scenarios. - Ensured backwards compatibility by maintaining existing behavior for valid configurations.
- Refactored `TargetMatcher` and `InclusionMatcher` to improve validation for nil values and non-hash attributes. - Centralized value formatting into new private methods (`formatted_values`, `normalize_to_array`) for clarity and reuse. - Enhanced logic for checking attribute presence and inclusion with guard clauses. - Reduced code duplication and improved error message generation for missing options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.