Merged
Conversation
serprex
reviewed
Jan 22, 2026
soh/soh/Enhancements/randomizer/location_access/overworld/lake_hylia.cpp
Outdated
Show resolved
Hide resolved
serprex
reviewed
Jan 22, 2026
serprex
reviewed
Jan 22, 2026
| break; | ||
| case SCENE_LON_LON_RANCH: | ||
| if (CVarGetInteger(CVAR_ENHANCEMENT("TimeSavers.SkipMiscInteractions"), IS_RANDO) && | ||
| if (CVarGetInteger(CVAR_ENHANCEMENT("TimeSavers.SkipMiscInteractions"), |
Owner
There was a problem hiding this comment.
won't this still skip when cvar is explicitly enabled? speak check should be outside cvar default
…_hylia.cpp Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
serprex
reviewed
Jan 22, 2026
Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
null
Build Artifacts