Skip to content

[#124] Delete toNum#136

Merged
Sereja313 merged 1 commit intomasterfrom
Sereja313/#124-delete-toNum
Oct 10, 2022
Merged

[#124] Delete toNum#136
Sereja313 merged 1 commit intomasterfrom
Sereja313/#124-delete-toNum

Conversation

@Sereja313
Copy link
Member

@Sereja313 Sereja313 commented Oct 9, 2022

Description

Problem: The toNum function was depricated in v1.3.0, we need to remove it in the next release.

Solution: Delete toNum

Related issue(s)

Fixes #124

✅ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
  • Public contracts

    • Any modifications of public contracts comply with the Evolution
      of Public Contracts
      policy.
    • I added an entry to the changelog if my changes are visible to the users
      and
    • provided a migration guide for breaking changes if possible

Stylistic guide (mandatory)

✓ Release Checklist

  • I updated the version number in o-clock.cabal.
  • I updated the changelog and moved everything
    under the "Unreleased" section to a new section for this release version.
  • If any definitions (functions, type classes, instances, etc) were added,
    I added @since haddock annotations.
  • (After merging) I created a new entry in the releases page,
    with a summary of all user-facing changes.
    • I made sure a tag was created using the format vX.Y.Z
  • (After merging) I uploaded the package to hackage.

Problem: The `toNum` function was depricated in v1.3.0, we need to
remove it in the next release.

Solution: Delete `toNum`
@Sereja313 Sereja313 force-pushed the Sereja313/#124-delete-toNum branch from 18d5116 to ce5c208 Compare October 9, 2022 06:28
@Sereja313 Sereja313 requested a review from dcastro October 9, 2022 06:34
@Sereja313 Sereja313 merged commit 4059689 into master Oct 10, 2022
@Sereja313 Sereja313 deleted the Sereja313/#124-delete-toNum branch October 10, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid accidental flooring when converting Time unit to numeric types

2 participants