[#124] [#130] Add lossless conversion to Fractional values#129
Merged
breakerzirconia merged 1 commit intomasterfrom Jun 20, 2022
Merged
Conversation
dcastro
reviewed
Jun 13, 2022
dcastro
reviewed
Jun 13, 2022
dcastro
reviewed
Jun 18, 2022
dcastro
approved these changes
Jun 18, 2022
Member
dcastro
left a comment
There was a problem hiding this comment.
Good stuff, feel free to squash the fixups and merge ^^ 👍
Problem: The function 'toNum' transforms an object of the type 'Time timeunit' to a value of the type that satisfies the 'Num' constraint. However, the former object can contain a fractional value inside, which then needs to get floored before being converted to a Num value. This could lead to a possible loss of precision. Solution: create a separate function that converts the Time objects losslessly to a value of the type that satisfies a stricter constraint: 'Fractional'. The lossless conversion can be done via 'fromRational'.
4f4c270 to
7bb28d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The function
toNumtransforms an object of the typeTime timeunitto a value of the type that satisfies theNumconstraint. However, the former object can contain a fractional value
inside, which then needs to get floored before being converted to a
Numvalue. This could lead to a possible loss of precision.Solution: Create a separate function that converts the
Timeobjectslosslessly to a value of the type that satisfies a stricter constraint:
Fractional. The lossless conversion can be done viafromRational.Fixes #124
Fixes #130