Skip to content

Maintenance#125

Merged
gromakovsky merged 11 commits intomasterfrom
gromak/maintenance-nov21
Feb 10, 2022
Merged

Maintenance#125
gromakovsky merged 11 commits intomasterfrom
gromak/maintenance-nov21

Conversation

@gromakovsky
Copy link
Member

Some updates to make sure the repo stays up-to-date with the ecosystem.

This dependency is only used to import `coerce`, but it's also
available from `base`, so we can easily stop depending on it
and update its upper bound whenever it's updated.
Problem: `base` constraint doesn't follow PVP, `base-4.x` for
new `x` can break `o-clock` compilation/runtime behavior.

Solution: constrain it by `<4.17` constraint, check that it works
with recent `base` versions.
Also share some common parts using `common` stanza.
That requires us to increase `cabal-version` and move it to the top.
@gromakovsky gromakovsky self-assigned this Nov 9, 2021
Problem: there are 4 major GHC versions newer than 8.4, so we can freely
disregard versions older than 8.6. But we still have CPP conditional
checking that GHC version is 8.6 or newer.

Solution: drop that CPP check.
Also require `base >= 4.12` since it's the version bundled with 8.6.1
and it seems to be the standard approach.
@gromakovsky gromakovsky marked this pull request as ready for review November 9, 2021 07:25
@gromakovsky gromakovsky force-pushed the gromak/maintenance-nov21 branch 2 times, most recently from cf00692 to f5913b0 Compare November 9, 2021 07:29
@gromakovsky
Copy link
Member Author

I want to wait for ghc-9.2.1 to become available in https://github.com/haskell/actions/tree/main/setup

@gromakovsky gromakovsky force-pushed the gromak/maintenance-nov21 branch from 57c9d42 to 86bc384 Compare November 14, 2021 10:38
@gromakovsky
Copy link
Member Author

Okay, the next step to fully support GHC-9.2 is to wait for base constraint to be updated in tasty-hedgehog.

@gromakovsky gromakovsky disabled auto-merge November 14, 2021 10:47
@gromakovsky gromakovsky force-pushed the gromak/maintenance-nov21 branch from 86bc384 to d34e783 Compare December 28, 2021 19:47
@gromakovsky
Copy link
Member Author

Now waiting for hedgehog where the needed PR was merged just recently: hedgehogqa/haskell-hedgehog#436

@gromakovsky
Copy link
Member Author

Newer hedgehog is available, but now we need tasty-hedgehog to be updated once again.

@gromakovsky gromakovsky force-pushed the gromak/maintenance-nov21 branch 2 times, most recently from 1a34e2f to fd789e5 Compare February 4, 2022 12:36
That's a temporary change, we are waiting for `gauge` to
support latest GHC.
We only define instances, so nothing changes for us.
@gromakovsky gromakovsky force-pushed the gromak/maintenance-nov21 branch 4 times, most recently from 58b5df9 to 610210e Compare February 9, 2022 15:55
Problem: there is the following change in GHC-9.2.1:
> GHCi’s :kind! command now expands through type synonyms
> in addition to type families.

We have some doctests where we expect things like `18 :% 11` in
output of `:kind!`, but `:%` is a type synonym.
Those tests pass before GHC-9.2.1 because type synonym is not
expanded, but they fail starting from GHC-9.2.1 because
`:%` is expanded into `'::%`.

Solution: use CPP to expect different results depending on GHC version.
@gromakovsky gromakovsky force-pushed the gromak/maintenance-nov21 branch from 610210e to 84c3c41 Compare February 10, 2022 12:19
@gromakovsky
Copy link
Member Author

I encountered a number of other issues that were causing CI to fail in some configuration. It took me a while to resolve them, but now CI is finally green 🎉
Most of the changes are trivial, only the last commit is not entirely trivial, but it only affects comments (because doctest), so I guess I can go ahead and merge with the existing approval.

@gromakovsky gromakovsky merged commit 5bec906 into master Feb 10, 2022
@gromakovsky gromakovsky deleted the gromak/maintenance-nov21 branch February 10, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants