Merged
Conversation
This dependency is only used to import `coerce`, but it's also available from `base`, so we can easily stop depending on it and update its upper bound whenever it's updated.
Problem: `base` constraint doesn't follow PVP, `base-4.x` for new `x` can break `o-clock` compilation/runtime behavior. Solution: constrain it by `<4.17` constraint, check that it works with recent `base` versions. Also share some common parts using `common` stanza. That requires us to increase `cabal-version` and move it to the top.
Problem: there are 4 major GHC versions newer than 8.4, so we can freely disregard versions older than 8.6. But we still have CPP conditional checking that GHC version is 8.6 or newer. Solution: drop that CPP check. Also require `base >= 4.12` since it's the version bundled with 8.6.1 and it seems to be the standard approach.
cf00692 to
f5913b0
Compare
Member
Author
|
I want to wait for ghc-9.2.1 to become available in https://github.com/haskell/actions/tree/main/setup |
dcastro
reviewed
Nov 9, 2021
dcastro
approved these changes
Nov 9, 2021
57c9d42 to
86bc384
Compare
Member
Author
|
Okay, the next step to fully support GHC-9.2 is to wait for |
https://hackage.haskell.org/package/doctest-0.20.0/changelog Tests pass with 0.20.
86bc384 to
d34e783
Compare
Member
Author
|
Now waiting for |
Member
Author
|
Newer |
1a34e2f to
fd789e5
Compare
That's a temporary change, we are waiting for `gauge` to support latest GHC.
We only define instances, so nothing changes for us.
58b5df9 to
610210e
Compare
Problem: there is the following change in GHC-9.2.1: > GHCi’s :kind! command now expands through type synonyms > in addition to type families. We have some doctests where we expect things like `18 :% 11` in output of `:kind!`, but `:%` is a type synonym. Those tests pass before GHC-9.2.1 because type synonym is not expanded, but they fail starting from GHC-9.2.1 because `:%` is expanded into `'::%`. Solution: use CPP to expect different results depending on GHC version.
610210e to
84c3c41
Compare
Member
Author
|
I encountered a number of other issues that were causing CI to fail in some configuration. It took me a while to resolve them, but now CI is finally green 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some updates to make sure the repo stays up-to-date with the ecosystem.