Merged
Conversation
Problem: we write some tests using `hspec` and then convert them to tasty trees using `tasty-hspec`. This conversion is not necessary, but causes extra dependencies to be added to one test-suite. Moreover, sometimes it's not 100% precise. Solution: remove this dependency and group tests into trees ourselves. It doesn't add any overhead, we are just using a slightly different syntax. We don't transitively depend on `hspec` anymore, but we need `hspec-expectations` as a replacement to use things like `shouldThrow`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: we write some tests using
hspecand then convert them totasty trees using
tasty-hspec. This conversion is not necessary,but causes extra dependencies to be added to one test-suite.
Moreover, sometimes it's not 100% precise.
Solution: remove this dependency and group tests into trees ourselves.
It doesn't add any overhead, we are just using a slightly different
syntax.
We don't transitively depend on
hspecanymore, but we needhspec-expectationsas a replacement to use things likeshouldThrow.Resolves #120