Skip to content

Switch CI to GitHub Actions, update the repo#113

Merged
gromakovsky merged 12 commits intomasterfrom
gromak/github-actions
Jul 8, 2020
Merged

Switch CI to GitHub Actions, update the repo#113
gromakovsky merged 12 commits intomasterfrom
gromak/github-actions

Conversation

@gromakovsky
Copy link
Member

@gromakovsky gromakovsky commented Jul 8, 2020

  1. Remove some custom flags that give very small profit.
  2. Switch CI to GitHub Actions.
  3. Clean-up some things, increase some upper bounds, fix some issues caught by new CI.

@gromakovsky gromakovsky self-assigned this Jul 8, 2020
@gromakovsky gromakovsky force-pushed the gromak/github-actions branch from 4a21611 to 26804ff Compare July 8, 2020 13:16
@gromakovsky gromakovsky force-pushed the gromak/github-actions branch 2 times, most recently from ab9fa6e to bb8a324 Compare July 8, 2020 13:24
Problem: there is ghc-prim-0.6.1, but o-clock requires < 0.6.
Solution: since there are no breaking changes for us, we
update the upper bound.
We don't (officially) support these versions anyway.
Problem: GitHub Actions is more convenient to use in GitHub repos
than Travis CI. We are moving CIs in our simple public libraries to
GitHub Actions, but this repo is still using Travis.

Solution: remove .travis.yml and some files required by it, add
our standard GitHub Actions CI config instead.
Problem: we want to make sure our repo conforms with the REUSE
specification.

Solution: add a check for that to CI.
Problem: `tested-with` in .cabal file doesn't match our CI
config, also 8.4 is quite old.

Solution: stop supporting 8.4, update the list of supported GHC
versions to match the CI config.
@gromakovsky gromakovsky force-pushed the gromak/github-actions branch from bb8a324 to bab5161 Compare July 8, 2020 13:39
Problem: we have `deepseq`, `hashable` and `serialize` flags that
can be enabled to introduce some instances.
However, all these instances are based on `Generic` and default
implementations, so they take 1 line.
They add some mess and complicate maintenance, I think it's not
worth it for just one line of code.

Solution: remove these three flags and their special handling.
Problem: there is aeson 1.5 which we don't permit.
Solution: update its upper bound.
@gromakovsky gromakovsky force-pushed the gromak/github-actions branch from 1524e70 to ed6a054 Compare July 8, 2020 14:01
@gromakovsky gromakovsky changed the title [WIP] Switch CI to GitHub Actions, update the repo Switch CI to GitHub Actions, update the repo Jul 8, 2020
@gromakovsky
Copy link
Member Author

xrefcheck fails complaining about http://stackage.org/nightly/package/o-clock. It should be resolved soon once we make a new release (because it will hopefully go to nightly).

Problem: there are some issues with building two test-suites on
Windows.
Solution: for now we just disable them on Windows, they only
test documentation, so it's not a big deal.
@gromakovsky gromakovsky marked this pull request as ready for review July 8, 2020 14:44
@gromakovsky gromakovsky merged commit 4b017fd into master Jul 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the gromak/github-actions branch July 8, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant