Merged
Conversation
Problem: stack.yaml uses some old nightly resolver. It seems to be a common practice to use recent LTS. Solution: use latest LTS available at the moment – 14.8. We still support resolver with 8.4, for that purpose stack-8.4.4.yaml was added.
Problem: GHC-8.8 is a thing, we want to make sure that we can build o-clock using stack and latest GHC. Solution: add stack-8.8.1.yaml which uses nightly resolver with GHC-8.8.1. Add such build to Travis config. Also add cabal build with 8.8.1 and update o-clock.cabal (tested-with).
Problem: we support GHC versions starting from 8.0, but 8.0 and 8.2 lack several features and it requires us to use CPP in many cases to detect GHC version. Nowadays there are also 8.4, 8.6 and 8.6. My personal opinion is that it is sufficient to support only the latest three. It makes maintenance easier. Solution: remove old stack.yaml configs, remove relevant lines from Travis config, remove most of CPP checks from code.
Problem: there are new versions of some dependencies but out upper bounds do not permit using them. Solution: update upper bounds to permit latest versions. I've checked that there are apparently no breaking changes that matter for us.
Problem: our benchmarks depend on `time-units` and `tiempo` which are rather dead libraries. Because of that we have to specify `allow-newer` in Stack configurations and nightly resolver does not have `o-clock` because it cares about benchmarks and these dependencies are not in the resolver. Solution: so we conditionally make benchmarks not buildable. One still can build them by passing a new flag.
There are important changes so we would like to release a new version.
kirelagin
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resurrect
o-clockin nightly resolver. Specifically:allow-neweroption.Fixes #110.