Inline TraceId and SpanId JSON string formatting#2215
Merged
nblumhardt merged 2 commits intoserilog:devfrom Jan 28, 2026
Merged
Inline TraceId and SpanId JSON string formatting#2215nblumhardt merged 2 commits intoserilog:devfrom
nblumhardt merged 2 commits intoserilog:devfrom
Conversation
Replaces usage of JsonValueFormatter.WriteQuotedJsonString for TraceId and SpanId with direct writing of quoted string values. activitytraceid is only either numbers or lower-case hexadecimal https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.activitytraceid.createfromstring?view=net-8.0#exceptions same for activityspanid https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.activityspanid.createfromstring?view=net-8.0#exceptions
Member
|
Nice one 👍 |
Merged
This was referenced Feb 10, 2026
This was referenced Mar 29, 2026
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces usage of JsonValueFormatter.WriteQuotedJsonString for TraceId and SpanId with direct writing of quoted string values.
activitytraceid is only either numbers or lower-case hexadecimal https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.activitytraceid.createfromstring?view=net-8.0#exceptions
same for activityspanid
https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.activityspanid.createfromstring?view=net-8.0#exceptions