Remove backpressure from XMLDoc#2203
Merged
nblumhardt merged 1 commit intoserilog:devfrom Sep 26, 2025
Merged
Conversation
Because backpressure is not applied, instead events are discarded when the queue is full.
Member
|
Nice spotting - thanks! (Some leftovers from an earlier prototype, IIRC :-)) |
Merged
This was referenced Feb 10, 2026
This was referenced Mar 29, 2026
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because backpressure is not applied, instead events are discarded when the queue is full.
The xmldoc for
BatchingOptions.QueueLimitsays that backpressure is applied when the limit is exceeded.However, in
BatchingSink.cswe see that no backpressure is appliedInstead the event is discarded (which is good).
To me it looks like a mistake in the XMLDoc, and this PR adjusts it.