Merged
Conversation
- This PR removes a char[] allocation that is occuring in MessageTemplateParser. The fix is to instead create a static char[] that we then reference which removes the allocation altogether. This doesn't have a huge impact on the benchmark runtime though it does help eliminate a small allocation that was contributing to more GCs in the benchmark.
nblumhardt
reviewed
Sep 4, 2025
Member
nblumhardt
left a comment
There was a problem hiding this comment.
Nice find, Nik! Thanks for the PR, just had the one query.
Merged
This was referenced Feb 10, 2026
This was referenced Mar 29, 2026
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contributes a performance fix to remove some char[] allocations that are occurring in MessageTemplateParser. This trims ~10% of Gen0 memory usage in the MessageTemplateParsingBenchmark.DefaultConsoleOutputTemplate benchmark.
This fix was found by our new Copilot Profiler Agent as it was profiling and looking for different optimizations in the available benchmarks.
Before - 1776 Bytes
After - 1616 Bytes